linux-mips
[Top] [All Lists]

Re: [MIPS] SMTC: Fix crash on bootup with idebus= command line argument.

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [MIPS] SMTC: Fix crash on bootup with idebus= command line argument.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 13 Sep 2007 14:49:43 +0100
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.64N.0709121621200.24030@blysk.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64N.0709111431240.30365@blysk.ds.pg.gda.pl> <20070911.230712.39152979.anemo@mba.ocn.ne.jp> <Pine.LNX.4.64N.0709111509140.30365@blysk.ds.pg.gda.pl> <20070913.001809.106261283.anemo@mba.ocn.ne.jp> <Pine.LNX.4.64N.0709121621200.24030@blysk.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Wed, Sep 12, 2007 at 04:54:08PM +0100, Maciej W. Rozycki wrote:

>  I gather the problem is ide_probe_legacy() is called too early for PCI to 
> have been initialised.  With the old code ide_probe_legacy() called 
> pci_get_class(), which in turn triggered PCI initialisation, which enabled 
> interrupts prematurely and the failure scenario happened.  To rectify Ralf 
> resurrected yet older code that reserved the legacy ports unconditionally.  
> You have put the code that calls pci_get_class() back and introduced this 
> call to no_pci_devices() beforehand.  Please correct me if I have been 
> wrong anywhere here.

Pci_get_class doesn't trigger PCI initialization and I don't think it
should ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>