linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS][7/7] AR7: ethernet

To: Thiemo Seufer <ths@networkno.de>
Subject: Re: [PATCH][MIPS][7/7] AR7: ethernet
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 13 Sep 2007 12:35:47 +0100
Cc: Matteo Croce <technoboy85@gmail.com>, linux-mips@linux-mips.org, Eugene Konev <ejka@imfi.kspu.ru>, netdev@vger.kernel.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@coreworks.de, openwrt-devel@lists.openwrt.org, Andrew Morton <akpm@linux-foundation.org>, Jeff Garzik <jgarzik@pobox.com>
In-reply-to: <20070913014246.GB15247@networkno.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200709080143.12345.technoboy85@gmail.com> <200709080223.00613.technoboy85@gmail.com> <20070912165029.GG4571@linux-mips.org> <20070913014246.GB15247@networkno.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Sep 13, 2007 at 02:42:46AM +0100, Thiemo Seufer wrote:

> > All struct members here are sized such that there is no padding needed, so
> > the packed attribute doesn't buy you anything - unless of course the
> > entire structure is missaligned but I don't see how that would be possible
> > in this driver so the __attribute__ ((packed)) should go - it result in
> > somwhat larger and slower code.
> 
> FWIW, a modern gcc will warn about such superfluous packed attributes,
> that's another reason to remove those.

I doubt it will in this case; the packed structure is dereferenced by a
pointer so no way for gcc to know the alignment.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>