| To: | yoichi_yuasa@tripeaks.co.jp |
|---|---|
| Subject: | Re: [PATCH][MIPS] move i8259 functions to include/asm-mips/i8259.h |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Thu, 13 Sep 2007 11:29:17 +0900 (JST) |
| Cc: | ralf@linux-mips.org, linux-mips@linux-mips.org |
| In-reply-to: | <200709130204.l8D244XV029841@po-mbox300.hop.2iij.net> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070912232333.22c4f7bb.yoichi_yuasa@tripeaks.co.jp> <20070913.003319.41011558.anemo@mba.ocn.ne.jp> <200709130204.l8D244XV029841@po-mbox300.hop.2iij.net> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Thu, 13 Sep 2007 11:04:04 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote: > diff -pruN -X mips/Documentation/dontdiff mips-orig/include/asm-mips/hw_irq.h > mips/include/asm-mips/hw_irq.h > --- mips-orig/include/asm-mips/hw_irq.h 2007-09-13 10:41:51.559222750 > +0900 > +++ mips/include/asm-mips/hw_irq.h 2007-09-13 10:39:56.480030750 +0900 > @@ -8,15 +8,8 @@ > #ifndef __ASM_HW_IRQ_H > #define __ASM_HW_IRQ_H > > -#include <linux/profile.h> > #include <asm/atomic.h> This breaks some build. linux/arch/mips/kernel/time.c:142: error: implicit declaration of function 'profile_tick' Proper fix would be including profile.h from time.c, but this is irrelevant to i8259, so should be a separate patch. Other parts looks good to me. Thanks. --- Atsushi Nemoto |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH][MIPS] move i8259 functions to include/asm-mips/i8259.h, Yoichi Yuasa |
|---|---|
| Next by Date: | Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc..., Jeff Garzik |
| Previous by Thread: | [PATCH][MIPS] move i8259 functions to include/asm-mips/i8259.h, Yoichi Yuasa |
| Next by Thread: | [PATCH][MIPS] add #include <linux/profile.h> to arch/mips/kernel/time.c, Yoichi Yuasa |
| Indexes: | [Date] [Thread] [Top] [All Lists] |