linux-mips
[Top] [All Lists]

Re: [MIPS] SMTC: Fix crash on bootup with idebus= command line argument.

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [MIPS] SMTC: Fix crash on bootup with idebus= command line argument.
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Wed, 12 Sep 2007 18:19:29 +0100 (BST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20070913.015520.51867978.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64N.0709111509140.30365@blysk.ds.pg.gda.pl> <20070913.001809.106261283.anemo@mba.ocn.ne.jp> <Pine.LNX.4.64N.0709121621200.24030@blysk.ds.pg.gda.pl> <20070913.015520.51867978.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 13 Sep 2007, Atsushi Nemoto wrote:

> The pci_get_class() failure was happened only if ide_probe_legacy() was
> called too early.  That can happen if you specified some IDE boot
> options, such as "idebus=" option.
> 
> So if you do not add any ide boot option, there should be no problem.
> 
> If you meant "ide_probe_legacy() has been broken with ide boot options
> for long years", I agree.

 You mean the point ide_probe_legacy() is called at during bootstrap 
depends on whether some IDE boot options have been specified or not?  
Well, that is an... interesting approach indeed.

> And my recent patch is not to solve this problem.  Just avoid adding
> legacy ide0/ide1 unconditionally in normal usage.

 Of course and it makes perfect sense then.  Thanks for your effort.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>