linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS] move i8259 functions to include/asm-mips/i8259.h

To: yoichi_yuasa@tripeaks.co.jp
Subject: Re: [PATCH][MIPS] move i8259 functions to include/asm-mips/i8259.h
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Thu, 13 Sep 2007 00:33:19 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20070912232333.22c4f7bb.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070912232333.22c4f7bb.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 12 Sep 2007 23:23:33 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> 
wrote:
> --- mips-orig/arch/mips/kernel/i8259.c        2007-09-12 14:37:15.447287000 
> +0900
> +++ mips/arch/mips/kernel/i8259.c     2007-09-12 14:26:42.007699500 +0900
> @@ -31,7 +31,10 @@
>  static int i8259A_auto_eoi = -1;
>  DEFINE_SPINLOCK(i8259A_lock);
>  /* some platforms call this... */
> -void mask_and_ack_8259A(unsigned int);
> +static void disable_8259A_irq(unsigned int irq);
> +static void enable_8259A_irq(unsigned int irq);
> +static void mask_and_ack_8259A(unsigned int irq);
> +static void init_8259A(int auto_eoi);
>  
>  static struct irq_chip i8259A_chip = {
>       .name           = "XT-PIC",

Please drop a comment in this part too.  The comment was there just
because we had to drop "static" from mask_and_ack_8259A() at that
time.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>