linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS][4/7] AR7: leds driver

To: Matteo Croce <technoboy85@gmail.com>
Subject: Re: [PATCH][MIPS][4/7] AR7: leds driver
From: Richard Purdie <rpurdie@rpsys.net>
Date: Tue, 11 Sep 2007 22:43:29 +0100
Cc: linux-mips@linux-mips.org, Nicolas Thill <nico@openwrt.org>, openwrt-devel@lists.openwrt.org, Andrew Morton <akpm@linux-foundation.org>
In-reply-to: <200709080220.49064.technoboy85@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200709080143.12345.technoboy85@gmail.com> <200709080220.49064.technoboy85@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 2007-09-08 at 02:20 +0200, Matteo Croce wrote:
> Support for the leds in front of the board usually used to show power
> status, network traffic, connected eth devices etc.
> 
> Signed-off-by: Matteo Croce <technoboy85@gmail.com>
> Signed-off-by: Nicolas Thill <nico@openwrt.org>

The usual approach to drivers like this is to add the device definition
(ar7_leds_device) to the platform specific code which is probably in
arch/mips/ somewhere? See arch/arm/mach-pxa/{corgi|poodle|spitz}.c for
example.

Also, does MIPS have any kind of generic GPIO framework? A quick look at
the code suggests you might be able to use drivers/leds/leds-gpio.c
although you might need to add a definition of gpio_set_value_cansleep()
since MIPS appears to lack it.

Regards,

Richard
(LED Maintainer)


<Prev in Thread] Current Thread [Next in Thread>