linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] forbid asm/bitops.h direct inclusion

To: Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH 2/2] forbid asm/bitops.h direct inclusion
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 10 Sep 2007 13:28:38 +0100
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Adrian Bunk <bunk@kernel.org>, rth@twiddle.net, hskinnemoen@atmel.com, uclinux-dist-devel@blackfin.uclinux.org, dev-etrax@axis.com, dhowells@redhat.com, discuss@x86-64.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, sparclinux@vger.kernel.org, chris@zankel.net
In-reply-to: <276116173913632310@pripojeni.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <30483262301654323266@pripojeni.net> <276116173913632310@pripojeni.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Sat, Sep 08, 2007 at 09:00:48PM +0100, Jiri Slaby wrote:

> forbid asm/bitops.h direct inclusion
> 
> Because of compile errors that may occur after bit changes if asm/bitops.h is
> included directly without e.g. linux/kernel.h which includes linux/bitops.h, 
> forbid
> direct inclusion of asm/bitops.h. Thanks to Adrian Bunk.

This is the kind of thing that checkpatch.pl is already checking for and
I like that idea much more than adding thousands of checks over many of
the header files under asm.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>