linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS][7/7] AR7: ethernet

To: Matteo Croce <technoboy85@gmail.com>
Subject: Re: [PATCH][MIPS][7/7] AR7: ethernet
From: Jeff Garzik <jgarzik@pobox.com>
Date: Fri, 07 Sep 2007 19:04:15 -0400
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org, ejka@imfi.kspu.ru, netdev@vger.kernel.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@coreworks.de
In-reply-to: <200709070121.42629.technoboy85@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200708201704.11529.technoboy85@gmail.com> <200709061734.11170.technoboy85@gmail.com> <20070906153025.7cb71cb1.akpm@linux-foundation.org> <200709070121.42629.technoboy85@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.5 (X11/20070719)
Matteo Croce wrote:
Il Friday 07 September 2007 00:30:25 Andrew Morton ha scritto:
On Thu, 6 Sep 2007 17:34:10 +0200 Matteo Croce <technoboy85@gmail.com> wrote:
Driver for the cpmac 100M ethernet driver.
It works fine disabling napi support, enabling it gives a kernel panic
when the first IPv6 packet has to be forwarded.
Other than that works fine.

I'm not too sure why I got cc'ed on this (and not on patches 1-6?) but
whatever.

I mailed every maintainer in the respective section in the file MAINTAINERS
and you were in the "NETWORK DEVICE DRIVERS" section

This patch introduces quite a number of basic coding-style mistakes. Please run it through scripts/checkpatch.pl and review the output.

Already done. I'm collecting other suggestions before committing

cool, I'll wait for the resend before reviewing, then.

As an author I understand that fixing up coding style / cosmetic stuff rather than "meat" is annoying.

But it is important to emphasize that a "clean" driver is what makes a good, thorough, effective review possible.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>