linux-mips
[Top] [All Lists]

Re: Suspicious test in dma-default.c

To: Maxime Bizon <mbizon@freebox.fr>
Subject: Re: Suspicious test in dma-default.c
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 4 Sep 2007 15:04:50 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1188550994.29619.10.camel@sakura.staff.proxad.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1188550994.29619.10.camel@sakura.staff.proxad.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Fri, Aug 31, 2007 at 11:03:14AM +0200, Maxime Bizon wrote:

> I don't know exactly why cpu_is_noncoherent_r10000() is needed, but the
> test looks wrong:
> 
>       return !plat_device_is_coherent(dev) &&
>              (current_cpu_data.cputype == CPU_R10000 &&
>              current_cpu_data.cputype == CPU_R12000);

I guess a processor need to be quite shizophrenic to pass this test ;-)

Patch applied, thanks.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: Suspicious test in dma-default.c, Ralf Baechle <=