linux-mips
[Top] [All Lists]

Re: flush_kernel_dcache_page() not needed ?

To: vagabon.xyz@gmail.com
Subject: Re: flush_kernel_dcache_page() not needed ?
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Tue, 04 Sep 2007 00:54:00 +0900 (JST)
Cc: linux-mips@linux-mips.org
In-reply-to: <46DC29F0.3060200@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <46D8089F.3010109@gmail.com> <20070903.225239.61509667.anemo@mba.ocn.ne.jp> <46DC29F0.3060200@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 03 Sep 2007 17:36:16 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
wrote:
> > Now copy_strings() calls this and I'm wondering we should implement or
> > not.  It seems the kernel works fine for me without the API...
>  
> Do you use a cpu with dcache aliasing issue ?

Yes.  4 way 32KB dcache.

> > Do you have any problem due to luck of the API?
> 
> No, but looking at copy_strings(), I think we can have some trouble.
> 
> BTW, do you recall flush_anon_page() and fuse bug ? It seems the same
> here...

Indeed.  But copy_strings() is not rare case (called on each execve),
so there might be some constraints which make us free from the
aliasing problem.  I'll look at it further, but any testcase are
welcome.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>