linux-mips
[Top] [All Lists]

Re: [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus.

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 28 Aug 2007 16:05:31 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20070825.002328.108738360.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <S20023984AbXHXBUC/20070824012002Z+18840@ftp.linux-mips.org> <20070825.002328.108738360.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Sat, Aug 25, 2007 at 12:23:28AM +0900, Atsushi Nemoto wrote:

> On Fri, 24 Aug 2007 02:19:57 +0100, linux-mips@linux-mips.org wrote:
> > Author: Ralf Baechle <ralf@linux-mips.org> Thu Aug 23 14:12:56 2007 +0100
> > Commit: dda571e0032731ed05b65e365283c54522483b08
> > Gitweb: http://www.linux-mips.org/g/linux/dda571e0
> > Branch: master
> > 
> > Since 96bde06a2df1b363206d3cdef53134b84ff37813 pcibios_fixup_bus's caller
> > pci_scan_child_bus is no longer marked __devinit resulting in this modpost
> > warning if PCI && !HOTPLUG:
> 
> And pci_read_bridge_bases() called by pcibios_fixup_bus is still
> marked __devinit.
> 
> Should we drop __devinit from pci_read_bridge_bases() too?

I already sent such a patch to gregkh on 23/8, so it'll just take a little
bit until this patch has propagated to Linus.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>