linux-mips
[Top] [All Lists]

[PATCH 1/6] mips: irix_getcontext will always fail EFAULT

To: linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] mips: irix_getcontext will always fail EFAULT
From: Andy Whitcroft <apw@shadowen.org>
Date: Thu, 16 Aug 2007 14:18:45 +0100
Cc: Randy Dunlap <rdunlap@xenotime.net>, Andrew Morton <akpm@osdl.org>, Andy Whitcroft <apw@shadowen.org>, Andy Whitcroft <apw@shadowen.org>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Inreply-to: <exportbomb.1187270320@pinky>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <exportbomb.1187270320@pinky>
Sender: linux-mips-bounce@linux-mips.org
Seems that a trailing ';' has slipped onto the end of the access_ok
check here, such that we will always return -EFAULT.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---
 arch/mips/kernel/irixsig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c
index 6980deb..28b2a8f 100644
--- a/arch/mips/kernel/irixsig.c
+++ b/arch/mips/kernel/irixsig.c
@@ -725,7 +725,7 @@ asmlinkage int irix_getcontext(struct pt_regs *regs)
               current->comm, current->pid, ctx);
 #endif
 
-       if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx)));
+       if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx)))
                return -EFAULT;
 
        error = __put_user(current->thread.irix_oldctx, &ctx->link);

<Prev in Thread] Current Thread [Next in Thread>