linux-mips
[Top] [All Lists]

Alchemy DMA and GFP_DMA

To: linux-mips@linux-mips.org
Subject: Alchemy DMA and GFP_DMA
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 16 Aug 2007 12:05:01 +0100
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
arch/mips/au1000/common/dbdma.c uses GFP_DMA in two places and I think
both instances are uncessary.  Could some alchmist confirm that both are
unnecessary?

Thanks,

  Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/au1000/common/dbdma.c b/arch/mips/au1000/common/dbdma.c
index 626de44..708b83b 100644
--- a/arch/mips/au1000/common/dbdma.c
+++ b/arch/mips/au1000/common/dbdma.c
@@ -397,7 +397,7 @@ au1xxx_dbdma_ring_alloc(u32 chanid, int entries)
         * slabs of memory.
         */
        desc_base = (u32)kmalloc(entries * sizeof(au1x_ddma_desc_t),
-                       GFP_KERNEL|GFP_DMA);
+                       GFP_KERNEL);
        if (desc_base == 0)
                return 0;
 
@@ -408,7 +408,7 @@ au1xxx_dbdma_ring_alloc(u32 chanid, int entries)
                kfree((const void *)desc_base);
                i = entries * sizeof(au1x_ddma_desc_t);
                i += (sizeof(au1x_ddma_desc_t) - 1);
-               if ((desc_base = (u32)kmalloc(i, GFP_KERNEL|GFP_DMA)) == 0)
+               if ((desc_base = (u32)kmalloc(i, GFP_KERNEL)) == 0)
                        return 0;
 
                desc_base = ALIGN_ADDR(desc_base, sizeof(au1x_ddma_desc_t));

<Prev in Thread] Current Thread [Next in Thread>