linux-mips
[Top] [All Lists]

Re: [alsa-devel] ALSA on MIPS platform

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [alsa-devel] ALSA on MIPS platform
From: Songmao Tian <tiansm@lemote.com>
Date: Wed, 08 Aug 2007 08:40:14 +0800
Cc: jiankemeng@gmail.com, linux-mips@linux-mips.org, alsa-devel@alsa-project.org, tiwai@suse.de, greg@kroah.com, ralf@linux-mips.org
In-reply-to: <20070807.230157.59463765.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <46B332AC.8020403@lemote.com> <5861a7880708062253x7133659cm1ff17f451e4f82f8@mail.gmail.com> <5861a7880708062317t21970c81w3f16580858bf50af@mail.gmail.com> <20070807.230157.59463765.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Icedove 1.5.0.8 (X11/20061116)
Atsushi Nemoto wrote:
On Tue, 7 Aug 2007 10:18:04 +0400, "Dajie Tan" <jiankemeng@gmail.com> wrote:
 static inline unsigned long virt_to_phys(volatile const void *address)
 {
-       return (unsigned long)address - PAGE_OFFSET + PHYS_OFFSET;
+       return ((unsigned long)address & 0x1fffffff) + PHYS_OFFSET;
 }

This makes virt_to_phys() a bit slower, and more importantly, breaks
64-bit kernel.

I have tried this way, and disassemble result show 32-bit kernel add only one instruction. But I don't really insist on this patch, for it doesn't resolve some driver code requirement.
---
Atsushi Nemoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel




<Prev in Thread] Current Thread [Next in Thread>