linux-mips
[Top] [All Lists]

Re: [PATCH -mm 2/4] MIPS: BCM947xx support (v2)

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH -mm 2/4] MIPS: BCM947xx support (v2)
From: Aurelien Jarno <aurelien@aurel32.net>
Date: Tue, 07 Aug 2007 10:04:47 +0200
Cc: mb@bu3sch.de, akpm@osdl.org, linux-mips@linux-mips.org, wbx@openwrt.org, nbd@openwrt.org, jolt@tuxbox.org
In-reply-to: <20070807094045.2c6eaa38.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070806150900.GG24308@hall.aurel32.net> <200708062005.29657.mb@bu3sch.de> <20070806183316.GB32465@hall.aurel32.net> <200708062037.05995.mb@bu3sch.de> <20070806191712.GA2019@hall.aurel32.net> <20070807094045.2c6eaa38.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: IceDove 1.5.0.10 (X11/20070329)
Yoichi Yuasa a écrit :
> On Mon, 6 Aug 2007 21:17:12 +0200
> Aurelien Jarno <aurelien@aurel32.net> wrote:
> 
>> The patch below against 2.6.23-rc1-mm2 adds support for BCM947xx CPUs.
>> It originally comes from the OpenWrt patches.
> <snip>
>> --- a/arch/mips/bcm947xx/prom.c
>> +++ b/arch/mips/bcm947xx/prom.c
>> @@ -0,0 +1,58 @@
>> +/*
>> + *  Copyright (C) 2004 Florian Schirmer <jolt@tuxbox.org>
>> + *
>> + *  This program is free software; you can redistribute  it and/or modify it
>> + *  under  the terms of  the GNU General  Public License as published by the
>> + *  Free Software Foundation;  either version 2 of the  License, or (at your
>> + *  option) any later version.
>> + *
>> + *  THIS  SOFTWARE  IS PROVIDED   ``AS  IS'' AND   ANY  EXPRESS OR IMPLIED
>> + *  WARRANTIES,   INCLUDING, BUT NOT  LIMITED  TO, THE IMPLIED WARRANTIES OF
>> + *  MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN
>> + *  NO  EVENT  SHALL   THE AUTHOR  BE    LIABLE FOR ANY   DIRECT, INDIRECT,
>> + *  INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
>> + *  NOT LIMITED   TO, PROCUREMENT OF  SUBSTITUTE GOODS  OR SERVICES; LOSS OF
>> + *  USE, DATA,  OR PROFITS; OR  BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
>> + *  ANY THEORY OF LIABILITY, WHETHER IN  CONTRACT, STRICT LIABILITY, OR TORT
>> + *  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
>> + *  THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>> + *
>> + *  You should have received a copy of the  GNU General Public License along
>> + *  with this program; if not, write  to the Free Software Foundation, Inc.,
>> + *  675 Mass Ave, Cambridge, MA 02139, USA.
>> + */
>> +
>> +#include <linux/init.h>
>> +#include <linux/mm.h>
>> +#include <linux/sched.h>
>> +#include <linux/bootmem.h>
>> +
>> +#include <asm/addrspace.h>
>> +#include <asm/bootinfo.h>
>> +#include <asm/pmon.h>
>> +
>> +const char *get_system_type(void)
>> +{
>> +    return "Broadcom BCM947xx";
>> +}
>> +
>> +void __init prom_init(void)
>> +{
>> +    unsigned long mem;
>> +
>> +    mips_machgroup = MACH_GROUP_BRCM;
>> +    mips_machtype = MACH_BCM947XX;
> 
> If you don't have a plan using mips_machgroup/mips_machtype,
> it is not a must. 

It is not used in other parts of the code, so we can remove that part. I
will update my patch.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

<Prev in Thread] Current Thread [Next in Thread>