linux-mips
[Top] [All Lists]

Re: [PATCH -mm 2/4] MIPS: BCM947xx support (v2)

To: Florian Schirmer <jolt@tuxbox.org>
Subject: Re: [PATCH -mm 2/4] MIPS: BCM947xx support (v2)
From: Aurelien Jarno <aurelien@aurel32.net>
Date: Tue, 07 Aug 2007 10:05:50 +0200
Cc: Michael Buesch <mb@bu3sch.de>, Andrew Morton <akpm@osdl.org>, linux-mips@linux-mips.org, Waldemar Brodkorb <wbx@openwrt.org>, Felix Fietkau <nbd@openwrt.org>
In-reply-to: <46B7851B.1050008@tuxbox.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070806150900.GG24308@hall.aurel32.net> <200708062005.29657.mb@bu3sch.de> <20070806183316.GB32465@hall.aurel32.net> <200708062037.05995.mb@bu3sch.de> <20070806191712.GA2019@hall.aurel32.net> <46B7851B.1050008@tuxbox.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: IceDove 1.5.0.10 (X11/20070329)
Florian Schirmer a écrit :
> Hi,
> 
> Aurelien Jarno wrote:
>> The patch below against 2.6.23-rc1-mm2 adds support for BCM947xx CPUs.
>> It originally comes from the OpenWrt patches.
>>
>> Cc: Michael Buesch <mb@bu3sch.de>
>> Cc: Waldemar Brodkorb <wbx@openwrt.org>
>> Cc: Felix Fietkau <nbd@openwrt.org>
>> Cc: Florian Schirmer <jolt@tuxbox.org>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>   
> 
> I'm not sure whether it's a good idea to export a symbol named "ssb". 
> Maybe bcm47xx_ssb would be a better name? I've no idea what the general 
> rule on exporting symbols is though. Otherwise:

I don't not either, but looking in other parts of the kernel it seems it
is done the other way, ie ssb_bcm947xx would be the correct name.

I will send an updated patch.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

<Prev in Thread] Current Thread [Next in Thread>