linux-mips
[Top] [All Lists]

Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig

To: Michael Buesch <mb@bu3sch.de>
Subject: Re: [PATCH -mm 3/4] MIPS: Add BCM947XX to Kconfig
From: Aurelien Jarno <aurelien@aurel32.net>
Date: Mon, 6 Aug 2007 20:33:51 +0200
Cc: Felix Fietkau <nbd@openwrt.org>, Andrew Morton <akpm@osdl.org>, linux-mips@linux-mips.org, Waldemar Brodkorb <wbx@openwrt.org>, Florian Schirmer <jolt@tuxbox.org>
In-reply-to: <200708062024.53952.mb@bu3sch.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070806150931.GH24308@hall.aurel32.net> <200708062009.14971.mb@bu3sch.de> <46B764D3.2030402@openwrt.org> <200708062024.53952.mb@bu3sch.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Mon, Aug 06, 2007 at 08:24:53PM +0200, Michael Buesch wrote:
> On Monday 06 August 2007, Felix Fietkau wrote:
> > Michael Buesch wrote:
> > 
> > > Shouldn't we leave the PCICORE an option instead of force selecting
> > > it here?
> > > My WRT54G doesn't have a (usable) PCI core. So it would work
> > > without the driver for it.
> > > Especially on the small WAP54G disabling PCIcore support could
> > > be useful to reduce the kernel size.
> > Yeah, leave it as an option, but I think a 'default y if BCM947XX' on
> > the PCICORE option would be reasonable, since many 47xx devices do have pci.
> 
> Yeah, probably a good idea.
> 

I will send a new patch to fix that.

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

<Prev in Thread] Current Thread [Next in Thread>