linux-mips
[Top] [All Lists]

Re: Sync SiByte system code to the new DUART driver

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: Sync SiByte system code to the new DUART driver
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 2 Aug 2007 12:26:22 +0100 (BST)
Cc: Imre Kaloz <kaloz@openwrt.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
In-reply-to: <20070802111314.GA25949@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <op.twfh4cuw2s3iss@ecaz.afh.b-m.hu> <20070802111314.GA25949@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2 Aug 2007, Ralf Baechle wrote:

> Hmm...  You just found the tip of the iceberg ...
> 
> $ git grep -w CONFIG_SIBYTE_SB1250_DUART | cat -
> arch/mips/configs/bigsur_defconfig:CONFIG_SIBYTE_SB1250_DUART=y
> arch/mips/configs/sb1250-swarm_defconfig:CONFIG_SIBYTE_SB1250_DUART=y
> arch/mips/sibyte/bcm1480/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/bcm1480/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/cfe/console.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/sb1250/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART
> arch/mips/sibyte/sb1250/irq.c:#ifdef CONFIG_SIBYTE_SB1250_DUART

 Most of that stuff does not work anymore anyway and now you risk link 
errors. ;-)  I do not think there is place for driver-related #ifdefs 
under arch/ anyway, the answer being platform devices.  Though chances are 
nobody might be bothered to ever implement them here.

 Also the #ifdefs in arch/mips/sibyte/cfe/console.c do not make sense to 
me.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>