linux-mips
[Top] [All Lists]

Re: [PATCH][resend] add support for profiling loongson2e

To: Dajie Tan <jiankemeng@gmail.com>
Subject: Re: [PATCH][resend] add support for profiling loongson2e
From: John Levon <levon@movementarian.org>
Date: Wed, 1 Aug 2007 13:38:40 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org>, oprofile-list@lists.sourceforge.net
In-reply-to: <20070801130109.GA5170@sw-linux.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070801130109.GA5170@sw-linux.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.9i
On Wed, Aug 01, 2007 at 05:01:09PM +0400, Dajie Tan wrote:

> diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c
> index a83c3db..fde9819 100644
> --- a/drivers/oprofile/cpu_buffer.c
> +++ b/drivers/oprofile/cpu_buffer.c
> @@ -148,6 +148,10 @@ add_sample(struct oprofile_cpu_buffer * cpu_buf,
>             unsigned long pc, unsigned long event)
>  {
>       struct op_sample * entry = &cpu_buf->buffer[cpu_buf->head_pos];
> +
> +     if(!entry)
> +             return;
> +

Perhaps I wasn't clear. This change is unacceptable and must not be
merged.

john

<Prev in Thread] Current Thread [Next in Thread>