linux-mips
[Top] [All Lists]

Re: Add errno definition to pm.h

To: "Steven J. Hill" <sjhill@realitydiluted.com>
Subject: Re: Add errno definition to pm.h
From: Songmao Tian <tiansm@lemote.com>
Date: Tue, 31 Jul 2007 08:46:44 +0800
Cc: linux-mips@linux-mips.org
In-reply-to: <20070730154552.GA4937@real.realitydiluted.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <46AE05DE.1020109@lemote.com> <20070730154552.GA4937@real.realitydiluted.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Icedove 1.5.0.8 (X11/20061116)
Steven J. Hill wrote:
On Mon, Jul 30, 2007 at 11:38:06PM +0800, Songmao Tian wrote:
commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
which need errno definition

Signed-off-by: Songmao Tian <tiansm@lemote.com>

diff --git a/include/linux/pm.h b/include/linux/pm.h
index e52f6f8..48b71ba 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -25,6 +25,7 @@

#include <linux/list.h>
#include <asm/atomic.h>
+#include <asm/errno.h>

You should be including <linux/errno.h> which then includes the
architecture-specific file. This patch should be rejected.

-Steve




Oh I see:)


Songmao Tian

<Prev in Thread] Current Thread [Next in Thread>