linux-mips
[Top] [All Lists]

Re: Add errno definition to pm.h

To: Songmao Tian <tiansm@lemote.com>
Subject: Re: Add errno definition to pm.h
From: "Steven J. Hill" <sjhill@realitydiluted.com>
Date: Mon, 30 Jul 2007 10:45:52 -0500
Cc: linux-mips@linux-mips.org
In-reply-to: <46AE05DE.1020109@lemote.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <46AE05DE.1020109@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Mon, Jul 30, 2007 at 11:38:06PM +0800, Songmao Tian wrote:
> commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
> static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
> which need errno definition
> 
> Signed-off-by: Songmao Tian <tiansm@lemote.com>
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index e52f6f8..48b71ba 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -25,6 +25,7 @@
> 
> #include <linux/list.h>
> #include <asm/atomic.h>
> +#include <asm/errno.h>
> 
You should be including <linux/errno.h> which then includes the
architecture-specific file. This patch should be rejected.

-Steve

<Prev in Thread] Current Thread [Next in Thread>