linux-mips
[Top] [All Lists]

A blind patch:)

To: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: A blind patch:)
From: Songmao Tian <tiansm@lemote.com>
Date: Mon, 30 Jul 2007 23:32:44 +0800
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Icedove 1.5.0.8 (X11/20061116)
commit 5fabf601a53079c182d5c25f6e850d6a7bd48988 is broken. since the regptr is disappeared in the signature of the function, I think the regptr is useless.


diff --git a/arch/mips/kernel/unaligned.c b/arch/mips/kernel/unaligned.c
index bbf20ce..1b94eef 100644
--- a/arch/mips/kernel/unaligned.c
+++ b/arch/mips/kernel/unaligned.c
@@ -281,9 +281,7 @@ static void emulate_load_store_insn(struct pt_regs *regs,
            : "r" (addr), "i" (-EFAULT));
        if (res)
            goto fault;
-        *regptr = &regs->regs[insn.i_format.rt];
        compute_return_epc(regs);
-        *regptr = value;
        break;
#endif /* CONFIG_64BIT */

@@ -324,9 +322,7 @@ static void emulate_load_store_insn(struct pt_regs *regs,
            : "r" (addr), "i" (-EFAULT));
        if (res)
            goto fault;
-        *regptr = &regs->regs[insn.i_format.rt];
        compute_return_epc(regs);
-        *regptr = value;
        break;
#endif /* CONFIG_64BIT */


<Prev in Thread] Current Thread [Next in Thread>