| To: | Heiko Carstens <heiko.carstens@de.ibm.com> |
|---|---|
| Subject: | Re: [PATCH] MIPS: add smp_call_function_single() |
| From: | Avi Kivity <avi@qumranet.com> |
| Date: | Sun, 29 Jul 2007 10:33:58 +0300 |
| Cc: | Stephane Eranian <eranian@hpl.hp.com>, Ralf Baechle <ralf@linux-mips.org>, linux-kernel@vger.kernel.org, mucci@cs.utk.edu, linux-mips@linux-mips.org, ak@suse.de, akpm@linux-foundation.org, Tony Luck <tony.luck@intel.com> |
| In-reply-to: | <20070728091950.GA4642@osiris.boeblingen.de.ibm.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070727124451.GC9828@frankl.hpl.hp.com> <20070727125533.GD5118@linux-mips.org> <20070727135323.GF9828@frankl.hpl.hp.com> <20070728091950.GA4642@osiris.boeblingen.de.ibm.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.0 (X11/20070419) |
Heiko Carstens wrote: This will not do the right thing. Semantics of smp_call_function_single() changed recently. It now is supposed to call func() locally with irqs disabled if cpu == smp_processor_id(). See i386/x86_64 and powerpc. Unfortunately ia64 hasn't been changed yet, so it will behave differently. A patch for ia64 has been submitted, presumably it's somewhere in the pipeline. -- error compiling committee.c: too many arguments to function |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 10/68] 0 -> NULL, for arch/mips, Markus Gothe |
|---|---|
| Next by Date: | klibc kernelheaders build failure on mips/mipsel, maximilian attems |
| Previous by Thread: | Re: [PATCH] MIPS: add smp_call_function_single(), Heiko Carstens |
| Next by Thread: | Re: [PATCH] MIPS: add smp_call_function_single(), Stephane Eranian |
| Indexes: | [Date] [Thread] [Top] [All Lists] |