linux-mips
[Top] [All Lists]

Re: [PATCH] Add support for profiling Loongson 2E

To: Dajie Tan <jiankemeng@gmail.com>
Subject: Re: [PATCH] Add support for profiling Loongson 2E
From: John Levon <levon@movementarian.org>
Date: Wed, 25 Jul 2007 13:52:35 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, inux-mips <linux-mips@linux-mips.org>, phil.el@wanadoo.fr, oprofile-list@lists.sourceforge.net
In-reply-to: <5861a7880707242041w32811dal6e2765747cbada32@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <5861a7880707240220g5d8129anc95e10bea833e323@mail.gmail.com> <20070724144051.GA17256@linux-mips.org> <5861a7880707242041w32811dal6e2765747cbada32@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.9i
On Wed, Jul 25, 2007 at 07:41:21AM +0400, Dajie Tan wrote:

> >Why do you need this change?  It almost looks as if you're papering over
> >a bug where add_sample should not be called at all.
> 
> Yeah,this change is to enhance the robust of oprofile. When using
> performace counter manually(writting control register in a module, no
> need to use the oprofile),I usually make kernel panic if I do not
> initialize the oprofile and enable the overflow interrupt carelessly.
> So, this change can avoid this panic. :D

This panic is good and should stay. It shows that you've made a mistake.

john

<Prev in Thread] Current Thread [Next in Thread>