linux-mips
[Top] [All Lists]

Re: [PATCH] Add support for profiling Loongson 2E

To: Dajie Tan <jiankemeng@gmail.com>
Subject: Re: [PATCH] Add support for profiling Loongson 2E
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 24 Jul 2007 15:40:51 +0100
Cc: linux-mips <linux-mips@linux-mips.org>, phil.el@wanadoo.fr, levon@movementarian.org, oprofile-list@lists.sourceforge.net
In-reply-to: <5861a7880707240220g5d8129anc95e10bea833e323@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <5861a7880707240220g5d8129anc95e10bea833e323@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Tue, Jul 24, 2007 at 01:20:27PM +0400, Dajie Tan wrote:

> This patch adds support for profiling Loongson 2E. It's been tested on
> FuLong mini PC(loongson2e inside).

First of all, your patch has been garbled when mailing.


[.. Lots of arch/mips code deleted ...]

No complaints upto this point.  But:

> diff -urN b/drivers/oprofile/cpu_buffer.c a/drivers/oprofile/cpu_buffer.c
> --- b/drivers/oprofile/cpu_buffer.c   2007-07-24 13:00:54.000000000 +0800
> +++ a/drivers/oprofile/cpu_buffer.c   2007-07-19 08:22:15.000000000 +0800
> @@ -148,6 +148,10 @@
>            unsigned long pc, unsigned long event)
> {
>       struct op_sample * entry = &cpu_buf->buffer[cpu_buf->head_pos];
> +
> +     if(!entry)
> +             return;
> +
>       entry->eip = pc;
>       entry->event = event;
>       increment_head(cpu_buf);

Why do you need this change?  It almost looks as if you're papering over
a bug where add_sample should not be called at all.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>