linux-mips
[Top] [All Lists]

Re: [PATCH] bcm1480 serial build fix

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] bcm1480 serial build fix
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 23 Jul 2007 14:21:56 +0100
Cc: Thiemo Seufer <ths@networkno.de>, linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.64N.0707231353030.13557@blysk.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070722075515.GB23747@networkno.de> <Pine.LNX.4.64N.0707231353030.13557@blysk.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Mon, Jul 23, 2007 at 02:00:16PM +0100, Maciej W. Rozycki wrote:

>  Aren't all the bits in "bcm1480_regs.h" meant to be prefixed with 
> BCM1480_DUART?  If these are to be the same as for the BCM1250, then they 
> can probably be defined "in sb1250_regs.h" unconditionally.
> 
>  These headers are a horrible mess anyway -- a single definition should be 
> enough to access the two DUARTs the BCM1480 seems to have...

The headers are autogenerated by Broadcom; they got some header-o-matic
which from a common source base will generate headers for Linux and
several other operating systems by adding (C) headers etc.  Which makes
sorting them tricky ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>