linux-mips
[Top] [All Lists]

Re: [PATCH] Fix known HW bug with MIPS core on NXP/Philips PNX8550

To: Daniel Laird <daniel.j.laird@nxp.com>
Subject: Re: [PATCH] Fix known HW bug with MIPS core on NXP/Philips PNX8550
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 19 Jul 2007 16:31:43 +0100 (BST)
Cc: linux-mips@linux-mips.org
In-reply-to: <469F822D.9040209@nxp.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <469F822D.9040209@nxp.com>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 19 Jul 2007, Daniel Laird wrote:

> @@ -435,6 +435,9 @@
>     label_nopage_tlbm,
>     label_smp_pgtable_change,
>     label_r3000_write_probe_fail,
> +#ifdef CONFIG_PNX8550
> +    label_pnx8550_bac_reset
> +#endif
> };
> 
> struct label {

 You have formatting problems (mailer suspected), a comma is missing from 
the above fragment and the whole proposal is a horrible #ifdef maze.  Can 
you please rewrite it in a more orderly fashion?

  Maciej

<Prev in Thread] Current Thread [Next in Thread>