linux-mips
[Top] [All Lists]

Re: [PATCH] User stack pointer randomisation

To: "Ralf Baechle" <ralf@linux-mips.org>
Subject: Re: [PATCH] User stack pointer randomisation
From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Date: Thu, 19 Jul 2007 17:16:09 +0200
Cc: nigel@mips.com, linux-mips <linux-mips@linux-mips.org>
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=fTBfKVSOrWYc6F8Q2M0tSnIojdtllbaiIXVrdvTNlKOIOdFEle47GswL0KEEnohf6A+QxTHGoPF1YF4lPkTUsfW9gswEA3G09e3WgLLd5OWEf3SgJl5VlVInFu+3AlrencuNzHs6AEQRcWckRczxUjHaEVCUk+McyZSfVDaRcHo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ozwip5JuuzvOvr8KEwEkGlzroYo4A19+eUUh+ECiKnKoo0ZpYZXazM6ByDzxpQF4XEIGfLX7TUBSRsOXBS8yG+oUvlnYbPrgdqZddfWMD2jJzlmCQaMxGziRVY77599vK95fDZopEJNcKOx3e3PA79mxLKf4ziiMKiICx1mMizM=
In-reply-to: <469F5BD9.3080601@innova-card.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <469F5345.5010209@innova-card.com> <20070719123030.GA21934@linux-mips.org> <469F5BD9.3080601@innova-card.com>
Sender: linux-mips-bounce@linux-mips.org
On 7/19/07, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
        if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)

actually this condition can be replaced by this simpler one:

       if (current->flags & PF_RANDOMIZE)

since PF_RANDOMIZE flag is raised if and only if the old condition is true.

At this point do you prefer a patch to amend these modifications or to
replace the old one ?

Sorry for the annoyance.
--
              Franck

<Prev in Thread] Current Thread [Next in Thread>