linux-mips
[Top] [All Lists]

Re: latest list of apparently "dead" CONFIG variables under arch/mips

To: Shane McDonald <mcdonald.shane@gmail.com>
Subject: Re: latest list of apparently "dead" CONFIG variables under arch/mips
From: "Robert P. J. Day" <rpjday@mindspring.com>
Date: Wed, 11 Jul 2007 19:03:45 -0400 (EDT)
Cc: linux-mips@linux-mips.org
In-reply-to: <b2b2f2320707111546p5b7e1c6dv60a8d600a28634e7@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64.0707111437480.12345@localhost.localdomain> <b2b2f2320707111546p5b7e1c6dv60a8d600a28634e7@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 11 Jul 2007, Shane McDonald wrote:

> The following are not "just pure junk", as PMC-Sierra is working on
> providing acceptable code that supports their MSP71xx processors.
> Patches to remove these are not required!
>
> On 7/11/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
> >
> > ========== PMCTWILED ==========
> > arch/mips/configs/msp71xx_defconfig:941:CONFIG_PMCTWILED=y
> > arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c:35:#ifdef CONFIG_PMCTWILED
> > arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c:85:#ifdef CONFIG_PMCTWILED
> > arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c:97:#ifdef CONFIG_PMCTWILED
> > arch/mips/pmc-sierra/msp71xx/msp_setup.c:249:#ifdef CONFIG_PMCTWILED
> > ========== SQUASHFS ==========
> > arch/mips/configs/msp71xx_defconfig:1307:CONFIG_SQUASHFS=y
> > arch/mips/pmc-sierra/msp71xx/msp_prom.c:46:#ifdef CONFIG_SQUASHFS
> > arch/mips/pmc-sierra/msp71xx/msp_prom.c:552:#ifdef CONFIG_SQUASHFS
> > arch/mips/pmc-sierra/msp71xx/msp_prom.c:554:            /* Get SQUASHFS
> > size */

i never *claimed* that they were junk, i was *asking* what was junk
since, typically, there's little value in testing preprocessor
variables if they aren't defined in a Kconfig file somewhere.  and if
something is not defined in a Kconfig file, it's generally a bad
choice to name it with a "CONFIG_" prefix.

in addition, i'm not sure what's going on with that SQUASHFS test,
since squashfs is not part of the kernel source tree, so what you're
testing for there is a mystery.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

<Prev in Thread] Current Thread [Next in Thread>