| To: | David Brownell <david-b@pacbell.net> |
|---|---|
| Subject: | Re: [PATCH 1/3] powerpc clk.h interface for platforms |
| From: | Christoph Hellwig <hch@lst.de> |
| Date: | Wed, 11 Jul 2007 18:16:33 +0200 |
| Cc: | Christoph Hellwig <hch@lst.de>, Domen Puncer <domen.puncer@telargo.com>, linuxppc-dev@ozlabs.org, Sylvain Munaut <tnt@246tnt.com>, linux-mips@linux-mips.org, Russell King <rmk@arm.linux.org.uk> |
| In-reply-to: | <200707110856.58463.david-b@pacbell.net> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070711093113.GE4375@moe.telargo.com> <20070711093220.GF4375@moe.telargo.com> <20070711103640.GB15536@lst.de> <200707110856.58463.david-b@pacbell.net> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.3.28i |
On Wed, Jul 11, 2007 at 08:56:58AM -0700, David Brownell wrote: > > Umm, this is about the fifth almost identical implementation of > > the clk_ functions. Please, please put it into common code. > > > > And talk to the mips folks which just got a similar comment from me. > > You mean like a lib/clock.c core, rather than an opsvector? I mean an ops vector and surrounding wrappers. Every architecture is reimplementing their own dispatch table which is rather annoying. What would a lib/clock.c do? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] powerpc clk.h interface for platforms, David Brownell |
|---|---|
| Next by Date: | Re: [PATCH][CFT] Move SB1250 DUART support to the serial subsystem, Maciej W. Rozycki |
| Previous by Thread: | Re: [PATCH 1/3] powerpc clk.h interface for platforms, David Brownell |
| Next by Thread: | Re: [PATCH 1/3] powerpc clk.h interface for platforms, David Brownell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |