linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] powerpc clk.h interface for platforms

To: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/3] powerpc clk.h interface for platforms
From: David Brownell <david-b@pacbell.net>
Date: Wed, 11 Jul 2007 08:56:58 -0700
Cc: Domen Puncer <domen.puncer@telargo.com>, linuxppc-dev@ozlabs.org, Sylvain Munaut <tnt@246tnt.com>, linux-mips@linux-mips.org, Russell King <rmk@arm.linux.org.uk>
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-YMail-OSG:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=WZAFku+W3BpFkdz6yAl06HX/yHDW+YXhje0nZILEbmQCgzDK2vTDwZUjhbza3wJ1zFsDIq9Gvhs5GEPNLDvyyhH9XYEgGiP+st6peKwhBIw6PX2p4A8obbmGE40wiVlIcsfS14SUCSiTlivhjEsYgUakRj0BHc3YYmrwEowFx98= ;
In-reply-to: <20070711103640.GB15536@lst.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070711093113.GE4375@moe.telargo.com> <20070711093220.GF4375@moe.telargo.com> <20070711103640.GB15536@lst.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.6
On Wednesday 11 July 2007, Christoph Hellwig wrote:
> On Wed, Jul 11, 2007 at 11:32:20AM +0200, Domen Puncer wrote:
> > clk interface for arch/powerpc, platforms should fill
> > clk_functions.
> 
> Umm, this is about the fifth almost identical implementation of
> the clk_ functions.  Please, please put it into common code.
> 
> And talk to the mips folks which just got a similar comment from me.

You mean like a lib/clock.c core, rather than an opsvector?

ISTR that allowing custom platform-specific implementations
was intended to be a feature.  But it's also true that some
folks see lack of shared implementation code as a drawback;
so I've CC'd Russell King (who originated the interface for
ARM platforms).

- Dave

<Prev in Thread] Current Thread [Next in Thread>