linux-mips
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] [MIPS] Fix resume for 64K page size

from [Maciej W. Rozycki] [Permanent Link][Original]
To: Peter Watkins <pwatkins@sicortex.com>
Subject: Re: [PATCH] [MIPS] Fix resume for 64K page size
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Tue, 10 Jul 2007 18:36:50 +0100 (BST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <11840880513393-git-send-email-pwatkins@sicortex.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11840880513393-git-send-email-pwatkins@sicortex.com>
Sender: linux-mips-bounce@linux-mips.org 
On Tue, 10 Jul 2007, pwatkins@sicortex.com wrote:

> @@ -85,7 +85,7 @@ #endif
>       move    $28, a2
>       cpu_restore_nonscratch a1
>  
> -#if (_THREAD_SIZE - 32) < 0x10000
> +#if (_THREAD_SIZE) < 0x10000
>       PTR_ADDIU       t0, $28, _THREAD_SIZE - 32
>  #else
>       PTR_LI          t0, _THREAD_SIZE - 32

 It looks wrong to me.  Shouldn't that be:

#if (_THREAD_SIZE - 32) < 0x8000

  Maciej
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] [MIPS] Fix resume for 64K page size, Thiemo Seufer
Next by Date:  [PATCH] [MIPS] Fix resume for 64k page size (#2)., pwatkins
Previous by Thread:  Re: [PATCH] [MIPS] Fix resume for 64K page size, Ralf Baechle
Next by Thread:  [PATCH] [MIPS] Fix resume for 64k page size (#2)., pwatkins
Indexes:  [Date] [Thread] [Top] [All Lists]