linux-mips
[Top] [All Lists]

Re: [MIPS] DEC: Fix modpost warning.

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [MIPS] DEC: Fix modpost warning.
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Tue, 10 Jul 2007 15:37:30 +0100 (BST)
Cc: linux-mips@linux-mips.org
In-reply-to: <20070710130409.GA14723@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <S20022577AbXGJLug/20070710115036Z+13637@ftp.linux-mips.org> <Pine.LNX.4.64N.0707101401001.18036@blysk.ds.pg.gda.pl> <20070710130409.GA14723@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 10 Jul 2007, Ralf Baechle wrote:

> >  It looks like a bogus warning -- I presume it comes from a reference from 
> > "sercons" to serial_console_setup() -- but the driver is going away, so I 
> > could not care less...
> 
> Yes, the root cause was the reference to serial_console_setup.  It's hard
> to teach modpost that this reference is bogus so I fixed the driver instead.
> Other console drivers had the same issue.

 I would not call this change a fix -- the cure is worse than the disease.

 We should maintain a table of references to ignore for modpost then.  It 
should be discarded together with other init data and given the number of 
such references it would be rather minuscule compared to code held in 
memory unnecessarily throughout the boot cycle of the system just to 
satisfy a debugging tool.  Which is a very useful one, no doubt, but 
please do not forget about the common sense.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>