linux-mips
[Top] [All Lists]

Re: dead(?) MIPS config stuff

To: "Kevin D. Kissell" <kevink@mips.com>
Subject: Re: dead(?) MIPS config stuff
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 5 Jul 2007 17:45:28 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20070705163658.GA22652@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070705144641.GA20210@linux-mips.org> <01dc01c7bf20$e03f6c20$10eca8c0@grendel> <20070705163658.GA22652@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Jul 05, 2007 at 05:36:58PM +0100, Ralf Baechle wrote:

> All this email was about were kernel configuration options that can't be
> enabled for some reason.  Of course these automated checkers such as
> Robert's make the assumption that the CONFIG_* preprocessor namespace
> is rserved for the Kconfig system.  In this particular case the reason
> is quite simple:
> 
> > arch/mips/kernel/process.c:54:#ifdef CONFIG_SMTC_IDLE_HOOK_DEBUG
> > arch/mips/Kconfig.debug:40:config CONFIG_SMTC_IDLE_HOOK_DEBUG
> 
> The kconfig system itself does prefix names with CONFIG_ so kconfig
> ends up defining CONFIG_CONFIG_SMTC_IDLE_HOOK_DEBUG (are we stuttuttering?)


From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 5 Jul 2007 17:39:48 +0100
Subject: [MIPS] SMTC: Fix cut'n'paste bug in Kconfig.debug

This effectivly turned the SMTC_IDLE_HOOK_DEBUG debug option into a no-op.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/Kconfig.debug b/arch/mips/Kconfig.debug
index 72d5c19..3efe117 100644
--- a/arch/mips/Kconfig.debug
+++ b/arch/mips/Kconfig.debug
@@ -37,7 +37,7 @@ config DEBUG_STACK_USAGE
 
          This option will slow down process creation somewhat.
 
-config CONFIG_SMTC_IDLE_HOOK_DEBUG
+config SMTC_IDLE_HOOK_DEBUG
        bool "Enable additional debug checks before going into CPU idle loop"
        depends on DEBUG_KERNEL && MIPS_MT_SMTC
        help

<Prev in Thread] Current Thread [Next in Thread>