linux-mips
[Top] [All Lists]

Re: [PATCH] TXx9 SPI controller driver (take 2)

To: david-b@pacbell.net
Subject: Re: [PATCH] TXx9 SPI controller driver (take 2)
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 01 Jul 2007 02:34:14 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, sshtylyov@ru.mvista.com, mlachwani@mvista.com, spi-devel-general@lists.sourceforge.net
In-reply-to: <200706300953.20156.david-b@pacbell.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070627.222458.27955527.anemo@mba.ocn.ne.jp> <200706300953.20156.david-b@pacbell.net>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 30 Jun 2007 09:53:19 -0700, David Brownell <david-b@pacbell.net> wrote:
> > This is a driver for SPI controller built into TXx9 MIPS SoCs.
> > This driver is derived from arch/mips/tx4938/toshiba_rbtx4938/spi_txx9.c.
> > 
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> > ---
> > Changes from previous version:
> 
> Better, but still not there yet.

Thanks!  I'll be back with take 3 patch.

> > +   txx9spi_cs_func(spi, c, 0, 1000000000 / 2 / spi->max_speed_hz);
> 
> You still use this confusing A/2/B syntax.  Please
> rewrite that using one "/" and one "*".  (And there
> is similar usage elsewhere.)

The compiler will optimize "1000000000 / 2 / spi->max_speed_hz" into
"500000000 / spi->max_speed_hz", so it can be treat as one "/", no?

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>