Re: [PATCH 1/12] mips: PMC MSP71xx core platform

[Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>]

Hi,

On Thu, 28 Jun 2007 19:05:30 -0600
Marc St-Jean <stjeanma@pmc-sierra.com> wrote:

> diff --git a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c 
> b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
> new file mode 100644
> index 0000000..6fa8572
> --- /dev/null
> +++ b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
> @@ -0,0 +1,179 @@
> +/*
> + * Sets up interrupt handlers for various hardware switches which are
> + * connected to interrupt lines.
> + *
> + * Copyright 2005-2207 PMC-Sierra, Inc.
                     ^^^^


> +
> +#ifdef CONFIG_PMC_MSP7120_GW

You have already set "obj-$(CONFIG_PMC_MSP7120_GW) += msp_hwbutton.o" in 
Makefile.
It is not necessary.

> +
> +static int __init msp_hwbutton_setup(void)
> +{
> +#ifdef CONFIG_PMC_MSP7120_GW

same.

Yoichi