Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs

[Atsushi Nemoto <anemo@mba.ocn.ne.jp>]

On Thu, 28 Jun 2007 10:54:14 -0400, Jeff Garzik <jeff@garzik.org> wrote:
> Seems to sane to me, by my quick read.
> 
> My only comment is:  if invalid MAC address, generate a random one using 
> get_random_bytes() like some other net drivers do, rather than just failing.
> 
> Users should be able to use the NIC even if the MAC is invalid -- after 
> all, they can set one using ifconfig even if it is not available at 
> driver load time.

Thank you for quick review!  I will update my patch with
get_random_bytes(). (maybe tomorrow ...)

---
Atsushi Nemoto