linux-mips
[Top] [All Lists]

Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs

To: jeff@garzik.org
Subject: Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Fri, 29 Jun 2007 00:04:14 +0900 (JST)
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, sshtylyov@ru.mvista.com, mlachwani@mvista.com
In-reply-to: <4683CB96.9090609@garzik.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070625.231502.69024828.anemo@mba.ocn.ne.jp> <20070628.230050.27955707.anemo@mba.ocn.ne.jp> <4683CB96.9090609@garzik.org>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 28 Jun 2007 10:54:14 -0400, Jeff Garzik <jeff@garzik.org> wrote:
> Seems to sane to me, by my quick read.
> 
> My only comment is:  if invalid MAC address, generate a random one using 
> get_random_bytes() like some other net drivers do, rather than just failing.
> 
> Users should be able to use the NIC even if the MAC is invalid -- after 
> all, they can set one using ifconfig even if it is not available at 
> driver load time.

Thank you for quick review!  I will update my patch with
get_random_bytes(). (maybe tomorrow ...)

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>