| To: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
|---|---|
| Subject: | Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs |
| From: | Jeff Garzik <jeff@garzik.org> |
| Date: | Thu, 28 Jun 2007 10:54:14 -0400 |
| Cc: | ralf@linux-mips.org, linux-mips@linux-mips.org, sshtylyov@ru.mvista.com, mlachwani@mvista.com |
| In-reply-to: | <20070628.230050.27955707.anemo@mba.ocn.ne.jp> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070622.232219.48807177.anemo@mba.ocn.ne.jp> <20070625002822.GD5814@linux-mips.org> <20070625.231502.69024828.anemo@mba.ocn.ne.jp> <20070628.230050.27955707.anemo@mba.ocn.ne.jp> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 1.5.0.12 (X11/20070530) |
Seems to sane to me, by my quick read.My only comment is: if invalid MAC address, generate a random one using get_random_bytes() like some other net drivers do, rather than just failing. Users should be able to use the NIC even if the MAC is invalid -- after all, they can set one using ifconfig even if it is not available at driver load time.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Generating patches and using checkpatch.pl, Daniel Laird |
|---|---|
| Next by Date: | Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs, Atsushi Nemoto |
| Previous by Thread: | Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs, Atsushi Nemoto |
| Next by Thread: | Re: [PATCH 3/4] rbtx4938: Fix secondary PCIC and glue internal NICs, Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |