linux-mips
[Top] [All Lists]

Re: [PATCH] generic clk API implementation for MIPS

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] generic clk API implementation for MIPS
From: Christoph Hellwig <hch@lst.de>
Date: Thu, 28 Jun 2007 10:37:25 +0200
Cc: hch@lst.de, vagabon.xyz@gmail.com, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20070628.112223.96686654.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cda58cb80706260820y4db3eacnae4dff0101852d52@mail.gmail.com> <20070627.013312.25479645.anemo@mba.ocn.ne.jp> <20070627153932.GA6016@lst.de> <20070628.112223.96686654.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.3.28i
On Thu, Jun 28, 2007 at 11:22:23AM +0900, Atsushi Nemoto wrote:
> On Wed, 27 Jun 2007 17:39:32 +0200, Christoph Hellwig <hch@lst.de> wrote:
> > > This MIPS implementation is derived (and stripped) from the SH
> > > implementation.
> > 
> > Why is this not in architecture-independent code?
> 
> Yes, this is architecture independent.  If we could have consensus on
> a generic (or least common) implementation, we can put it outside arch
> directory.
> 
> But I gave up for now ;) I will leave all implementation for platform
> code.

I really dislike duplicating thing over architectures.  If you copy code
from another architecture the first though should be 'could and should
this be generic ?'.  So please try to get this lifted to common code
instead of duplicating it.

> 
> ---
> Atsushi Nemoto
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>