linux-mips
[Top] [All Lists]

Re: [PATCH] Philips(NXP)/STB810 changes

To: Daniel Laird <daniel.j.laird@nxp.com>
Subject: Re: [PATCH] Philips(NXP)/STB810 changes
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 21 Jun 2007 15:27:21 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <11232209.post@talk.nabble.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11229250.post@talk.nabble.com> <467A67B6.6090909@ru.mvista.com> <11232209.post@talk.nabble.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Jun 21, 2007 at 05:37:25AM -0700, Daniel Laird wrote:

> Please find the new patch below - I hope it is following the correct rules
> now.

This is a good opportunity to advertise the checkpatch.pl script which is
part of the latest kernel once more.  For example running it against your
patch results gives:

[ralf@denk linux-queue]$ scripts/checkpatch.pl /tmp/xxx 
line over 80 characters
#107: FILE: arch/mips/philips/pnx8550/common/setup.c:117:
+                                  (PR4450_CMEM_SIZE_128MB << 
PR4450_CMEMB_SIZE) |

line over 80 characters
#112: FILE: arch/mips/philips/pnx8550/common/setup.c:122:
+                                  (PR4450_CMEM_SIZE_128MB << 
PR4450_CMEMB_SIZE) |

trailing whitespace
#141: 
>> +++ kernel-new/arch/mips/philips/pnx8550/common/setup.c $

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
[ralf@denk linux-queue]$ 


<Prev in Thread] Current Thread [Next in Thread>