linux-mips
[Top] [All Lists]

Re: [PATCH 1/12] mips: PMC MSP71xx core platform

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/12] mips: PMC MSP71xx core platform
From: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Date: Wed, 20 Jun 2007 09:58:34 -0700
Cc: linux-mips@linux-mips.org, Brian Oostenbrink <Brian_Oostenbrink@pmc-sierra.com>, Dan Doucette <Dan_Doucette@pmc-sierra.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.12 (X11/20070509)

Ralf Baechle wrote:
> On Thu, Jun 14, 2007 at 03:54:47PM -0600, Marc St-Jean wrote:
> 
>  > Re-posting patch as requested by Ralf. Changes since last post:
>  > -Minor cleanups as recommended by checkpatch.pl.
> 
> Be careful with that script.  Some of it's recommendations are harmful,
> for example when it sees an inclusion of <asm/time.h> it will suggest
> to use <linux/time.h>.  That's all fine because generally the file under
> linux/ will include the asm/ version but there are exception.

I discovered that on some patches, a few had to be reverted but no problem.

> But it's great that you discovered it already, it saves me the for both
> sides annoying part of dealing out tons of trivialities, first such as
> formatting trivialities.  One thing checkpatch.pl doesn't yet complain
> about is trailing whitespace such as in the first of the patches you
> sent:
> 
> Warning: trailing whitespace in line 106 of 
> arch/mips/pmc-sierra/msp71xx/msp_usb.c
> Warning: trailing whitespace in line 12 of 
> arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
> Warning: trailing whitespace in lines 43,53,63,79 of 
> arch/mips/pmc-sierra/msp71xx/msp_time.c
> Warning: trailing whitespace in lines 49,59,62,68,78,84 of 
> arch/mips/pmc-sierra/msp71xx/msp_irq.c
> Warning: trailing whitespace in line 84 of 
> arch/mips/pmc-sierra/msp71xx/msp_irq_cic.c
> Warning: trailing whitespace in line 157 of 
> arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
> Warning: trailing whitespace in lines 154,307,537,548,558 of 
> arch/mips/pmc-sierra/msp71xx/msp_prom.c
> Warning: trailing whitespace in lines 66,229,238,252 of 
> arch/mips/pmc-sierra/msp71xx/msp_setup.c
> 
> No need to resend the patch, I can strip that of trivially

Hmmm, I see. That's odd since it catches most trailing whitespace. I'll
email the maintainer if you haven't already. I've reported two other
issues to him before and he fixed the script in a day!

Marc

<Prev in Thread] Current Thread [Next in Thread>