linux-mips
[Top] [All Lists]

Re: [PATCH 7/12] drivers: PMC MSP71xx GPIO char driver

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 7/12] drivers: PMC MSP71xx GPIO char driver
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 20 Jun 2007 09:05:14 +0100
Cc: Marc St-Jean <stjeanma@pmc-sierra.com>, linux-mips@linux-mips.org
In-reply-to: <20070619141256.3d573a41.akpm@linux-foundation.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200706152046.l5FKk3NU015608@pasqua.pmc-sierra.bc.ca> <20070619141256.3d573a41.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Tue, Jun 19, 2007 at 02:12:56PM -0700, Andrew Morton wrote:

> > +/* Define the following for extra debug output */
> > +#undef DEBUG
> 
> The under shouldn't be needed: -DDEBUG can be provided on the kbuild
> command line.
> 
> > +#ifdef DEBUG
> > +#define DBG(args...) printk(KERN_DEBUG args)
> > +#else
> > +#define DBG(args...) do {} while (0)
> > +#endif

<linux/kernel.h> provides the equivalent pr_debug function so this
definition of DBG is redundant.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>