Re: [PATCH 5/5] Implement clockevents for R4000-style cp0 timer

["Franck Bui-Huu" <vagabon.xyz@gmail.com>]

On 6/18/07, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
> Hi Ralf,
>
> On 6/18/07, Ralf Baechle <ralf@linux-mips.org> wrote:
> > On Mon, Jun 18, 2007 at 04:22:39PM +0200, Franck Bui-Huu wrote:
> >
> > > were an interface for _generic_ rtc only. But all the following
> > > platforms don't seem to use the generic rtc though it initialises
> > > these function pointers... Any idea why ?
> >
> > Because unless drivers/char/Kconfig is getting changed to prevent that is
> > is possible to enable CONFIG_GEN_RTC, so this code was necessary for
> > correctness.
>
> Sorry I don't understand...
Ok I think I'm understanding now. So you mean that most of the
following platforms:

   arch/mips/ddb5xxx/common/rtc_ds1386.c
   arch/mips/dec/time.c
   arch/mips/lasat/setup.c
   arch/mips/mips-boards/atlas/atlas_setup.c
   arch/mips/mips-boards/malta/malta_setup.c
   arch/mips/momentum/ocelot_3/setup.c
   arch/mips/momentum/ocelot_c/setup.c
   arch/mips/pmc-sierra/yosemite/setup.c
   arch/mips/sgi-ip22/ip22-time.c
   arch/mips/sgi-ip32/ip32-setup.c
   arch/mips/sibyte/swarm/setup.c
   arch/mips/sni/a20r.c
   arch/mips/sni/pcimt.c
   arch/mips/sni/pcit.c
   arch/mips/sni/rm200.c
   arch/mips/tx4938/common/rtc_rx5c348.c

implements set and get rtc functions because genrtc can be enabled in
Kconfig ???

If so what about the following patch:

-- 8< --

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 55253a6..e8f3b0c 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -813,7 +813,7 @@ config SGI_IP27_RTC

config GEN_RTC
        tristate "Generic /dev/rtc emulation"
-       depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV &&
!S390 && !SUPERH
+       depends on RTC!=y && !IA64 && !ARM && !M32R && !SPARC && !FRV &&
!S390 && !SUPERH && !MIPS
        ---help---
          If you say Y here and create a character special file /dev/rtc with
          major number 10 and minor number 135 using mknod ("man mknod"), you
-- >8 --

and burn all the genrtc platform methods ?

Thanks
--
              Franck