linux-mips
[Top] [All Lists]

Re: [PATCH 5/5] Implement clockevents for R4000-style cp0 timer

To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Subject: Re: [PATCH 5/5] Implement clockevents for R4000-style cp0 timer
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 18 Jun 2007 16:14:22 +0100
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org
In-reply-to: <cda58cb80706180722n18e79a49vfa61450526e6af76@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11818164011355-git-send-email-fbuihuu@gmail.com> <11818164024053-git-send-email-fbuihuu@gmail.com> <20070614.212913.82089068.nemoto@toshiba-tops.co.jp> <20070617000448.GA30807@linux-mips.org> <cda58cb80706180722n18e79a49vfa61450526e6af76@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Mon, Jun 18, 2007 at 04:22:39PM +0200, Franck Bui-Huu wrote:

> were an interface for _generic_ rtc only. But all the following
> platforms don't seem to use the generic rtc though it initialises
> these function pointers... Any idea why ?

Because unless drivers/char/Kconfig is getting changed to prevent that is
is possible to enable CONFIG_GEN_RTC, so this code was necessary for
correctness.  Aside I think it did simply propagate through cutnpaste.
That at least was the reason in the 2.4 days when the old kernel
configuration language made it way to painful to deal with such
configurations.  These days I think we should rather get rid of genrtc.
Genrtc used to be nice candy but like most sweets long term it results in
caries ;-)

  Ralf

<Prev in Thread] Current Thread [Next in Thread>