linux-mips
[Top] [All Lists]

Re: [PATCH 5/5] Implement clockevents for R4000-style cp0 timer

To: ralf@linux-mips.org
Subject: Re: [PATCH 5/5] Implement clockevents for R4000-style cp0 timer
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 18 Jun 2007 02:23:14 +0900 (JST)
Cc: vagabon.xyz@gmail.com, linux-mips@linux-mips.org
In-reply-to: <20070617000448.GA30807@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11818164024053-git-send-email-fbuihuu@gmail.com> <20070614.212913.82089068.nemoto@toshiba-tops.co.jp> <20070617000448.GA30807@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Sun, 17 Jun 2007 01:04:48 +0100, Ralf Baechle <ralf@linux-mips.org> wrote:
> [MIPS] Switch from to_tm to rtc_time_to_tm
> 
> This replaces the MIPS-specific to_tm function with the generic
> rtc_time_to_tm function.  The big difference between the two functions is
> that rtc_time_to_tm uses epoch 70 while to_tm uses 1970, so the result of
> rtc_time_to_tm needs to be fixed up.
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Thanks, looks good to me except a few things.

>  arch/mips/momentum/jaguar_atx/setup.c  |    8 ++++-

Zombie? ;)

>  arch/mips/momentum/ocelot_c/setup.c    |    8 ++++-

Likely zombie?

>  include/asm-mips/time.h                |    7 ----
>  12 files changed, 36 insertions(+), 73 deletions(-)

And on more.

diff --git a/include/asm-mips/rtc.h b/include/asm-mips/rtc.h
index 82ad401..42d049f 100644
--- a/include/asm-mips/rtc.h
+++ b/include/asm-mips/rtc.h
@@ -33,8 +33,7 @@ static inline unsigned int get_rtc_time(struct rtc_time *time)
        unsigned long nowtime;
 
        nowtime = rtc_mips_get_time();
-       to_tm(nowtime, time);
-       time->tm_year -= 1900;
+       rtc_time_to_tm(nowtime, time);
 
        return RTC_24H;
 }

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>