linux-mips
[Top] [All Lists]

Re: [PATCH 12/12] drivers: PMC MSP71xx security engine driver

To: Marc St-Jean <stjeanma@pmc-sierra.com>
Subject: Re: [PATCH 12/12] drivers: PMC MSP71xx security engine driver
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Date: Fri, 15 Jun 2007 10:38:52 +0400
Cc: davem@davemloft.net, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <200706142212.l5EMCrc7024809@pasqua.pmc-sierra.bc.ca>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200706142212.l5EMCrc7024809@pasqua.pmc-sierra.bc.ca>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.9i
Hi Marc.

On Thu, Jun 14, 2007 at 04:12:53PM -0600, Marc St-Jean 
(stjeanma@pmc-sierra.com) wrote:
> [PATCH 12/12] drivers: PMC MSP71xx security engine driver
> 
> Patch to add an security engien driver for the PMC-Sierra MSP71xx devices.

Does this board have SMP config or can this adapter be found in SMP
systems, since you only protect against interrupts, but not 
simultaneous SMP access to the engine.

And as a minor nit: there is no check for dma_alloc_coherent() return value.

-- 
        Evgeniy Polyakov

<Prev in Thread] Current Thread [Next in Thread>