linux-mips
[Top] [All Lists]

Re: [PATCH 3/5] Deforest the function pointer jungle in the time code.

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH 3/5] Deforest the function pointer jungle in the time code.
From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Date: Thu, 14 Jun 2007 16:31:47 +0200
Cc: "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>, linux-mips@linux-mips.org, "Ralf Baechle" <ralf@linux-mips.org>
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BO8ZE9KmjLS69JSvmvqmaTYny6OWZ0lp2SpFwkx5o4r9nv3QioxdqdhRlap3GGvXgrDsXxm7Dxh7axO58xh5lK7N9+VVTWIY2SFH+OEOoqs47vtLQaPv+bmQx2nhr50/GCQwhwfOLdSrX2wllGK/hOx6g1gceo3KA5n9moA5uGk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=LkRr9+DPds71/7er9fFBX2ACUR6NH3ryWyLRWqekr941rB8u5p0HVhFEQiZOfe/bkMLN/staCsl8UAj7nmPVADZEIdBTlfWqFuZ4Wmhvi8Ccac2KLtHTnKprRpoepM9sqbXqZCQaTTZOFTQI3HCawKuKK8Tcz/kWvlvYFXCqPbY=
In-reply-to: <Pine.LNX.4.64N.0706141501080.25868@blysk.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11818164011355-git-send-email-fbuihuu@gmail.com> <11818164023940-git-send-email-fbuihuu@gmail.com> <20070614111748.GA8223@alpha.franken.de> <cda58cb80706140643g63c3bf34sbd5b843a15653c3d@mail.gmail.com> <Pine.LNX.4.64N.0706141501080.25868@blysk.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
Hi,

On 6/14/07, Maciej W. Rozycki <macro@linux-mips.org> wrote:
On Thu, 14 Jun 2007, Franck Bui-Huu wrote:

> The current code doesn't automatically calibrate any hpt. It was
> really hard to guess which ones need that so now if you need to
> calibrate your hpt, then you have to call calibrate_hpt().

 You are wrong -- calibration is currently automatic if a platform
provides a HPT, but has not set up its frequency:

Well it all depends on what you call "current" code... My own fault I
should have said "new" instead of "current", sorry.

Which should normally be the case unless there is no way to do
calibration, when a platform can provide a hardcoded value.  There is
nothing to guess here.


Are you sure it's the normal case? I would say that only DEC needs
that calibration:

Doing the following on the _current_ tree:

$ git grep -l mips_timer_state arch/mips
arch/mips/dec/time.c
arch/mips/kernel/time.c

 I'll have a look at your patches, but I hope you have got about the most
interesting configuration right, which is the DEC platform, where you can
have one of these:

As I said, all platforms haven't been migrated, but DEC seems an
interesting one to migrate. I'll try to do it and see if you can
accept such changes.


1. No HPT at all.

2. HPT in the chipset.

3. HPT in CP0.

depending on the configuration as determined at the run time, with no
predefined frequency in the cases #2 and #3.


Good to know.

Thanks
--
              Franck

<Prev in Thread] Current Thread [Next in Thread>