linux-mips
[Top] [All Lists]

Re: [PATCH 3/5] Deforest the function pointer jungle in the time code.

To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Subject: Re: [PATCH 3/5] Deforest the function pointer jungle in the time code.
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 14 Jun 2007 15:09:31 +0100 (BST)
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <cda58cb80706140643g63c3bf34sbd5b843a15653c3d@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11818164011355-git-send-email-fbuihuu@gmail.com> <11818164023940-git-send-email-fbuihuu@gmail.com> <20070614111748.GA8223@alpha.franken.de> <cda58cb80706140643g63c3bf34sbd5b843a15653c3d@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 14 Jun 2007, Franck Bui-Huu wrote:

> The current code doesn't automatically calibrate any hpt. It was
> really hard to guess which ones need that so now if you need to
> calibrate your hpt, then you have to call calibrate_hpt().

 You are wrong -- calibration is currently automatic if a platform 
provides a HPT, but has not set up its frequency:

                if (!mips_hpt_frequency)
                        mips_hpt_frequency = calibrate_hpt();

Which should normally be the case unless there is no way to do 
calibration, when a platform can provide a hardcoded value.  There is 
nothing to guess here.

 I'll have a look at your patches, but I hope you have got about the most 
interesting configuration right, which is the DEC platform, where you can 
have one of these:

1. No HPT at all.

2. HPT in the chipset.

3. HPT in CP0.

depending on the configuration as determined at the run time, with no 
predefined frequency in the cases #2 and #3.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>