linux-mips
[Top] [All Lists]

Re: [PATCH] override of arch/mips/mm/cache.c: __uncached_access

To: Fuxin Zhang <zhangfx@lemote.com>
Subject: Re: [PATCH] override of arch/mips/mm/cache.c: __uncached_access
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 7 Jun 2007 18:05:42 +0100
Cc: tiansm@lemote.com, linux-mips@linux-mips.org
In-reply-to: <4667A443.8060105@lemote.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070606182814.GD30017@linux-mips.org> <11811962573610-git-send-email-tiansm@lemote.com> <4667A443.8060105@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.14 (2007-02-12)
On Thu, Jun 07, 2007 at 02:22:59PM +0800, Fuxin Zhang wrote:

> For example,if we are using this memory layout:
> 0-256MB phys mem
> 256-512M pci io/mem region
> 512-768MB phys mem
> Xorg will crash due to pci video memory mapping problem.
> 
> So this is not really only for Fulong.
> 
> BTW:
> Songmao, we'd better add a comment to justify this code.

Note I didn't fundamentally object to the patch; it was rather a a question
of _how_ to do it.  The patch I put into the -queue tree will allow you
to put all the Fulong-specifics into the Fulong code rather than the
generic code.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>