linux-mips
[Top] [All Lists]

Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driv er

To: Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driv er
From: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Date: Tue, 5 Jun 2007 17:47:12 -0700
Cc: david-b@pacbell.net, gregkh@suse.de, linux-mips@linux-mips.org, akpm@linux-foundation.org, linux-usb-devel@lists.sourceforge.net
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.12 (X11/20070509)
Alan Stern wrote:
> On Mon, 4 Jun 2007, Marc St-Jean wrote:
> 
>  > [PATCH 11/12] drivers: PMC MSP71xx USB driver
>  >
>  > Patch to add an USB driver for the PMC-Sierra MSP71xx devices.
>  >
>  > Patches 1 through 10 were posted to linux-mips@linux-mips.org as well
>  > as other sub-system lists/maintainers as appropriate. This patch has
>  > some dependencies on the first few patches in the set. If you would
>  > like to receive these or the entire set, please email me.
> 
> My personal impressions:
> 
> This does far too much to be a single patch.  It needs to be broken up.
> 
> The change to hub.c looks more complicated than necessary.  You ought
> to be able to share more of the code.  Turning off power to the
> overcurrent port would probably be okay for any hub.
> 
> The changes to file_storage.c and other gadget drivers look completely
> unnecessary.  You're apparently trying to disallow 0-length transfers
> on endpoint 0.  For one thing, that's liable to break some protocols. 
> For another, it would be better to make the test at one place, in your
> controller driver, instead of spread out among multiple gadget drivers.
> 
> Alan Stern


Thanks to everyone that provided feedback. I'll be resubmitting the host
code only and will resume with gadget once the host is accepted.

The host only patch is still ~50k but that's mostly due to all the
le32 -> ehci32 conversion in order to support the big endian controller.
The actual platform driver code is small.

Marc


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [linux-usb-devel] [PATCH 11/12] drivers: PMC MSP71xx USB driv er, Marc St-Jean <=